Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Test_GetChainFeePriceUpdates #15240

Open
wants to merge 5 commits into
base: ccipreader-tests
Choose a base branch
from
Open

Add Test_GetChainFeePriceUpdates #15240

wants to merge 5 commits into from
+142 −3

Conversation

asoliman92
Copy link
Contributor

No description provided.

@asoliman92 asoliman92 requested review from a team as code owners November 14, 2024 10:51
@asoliman92 asoliman92 requested review from winder, rstout, makramkd, dimkouv, mateusz-sekara, 0xAustinWang and 0xnogo and removed request for a team November 14, 2024 10:51
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

AER Report: CI Core

aer_workflow , commit , Detect Changes , Scheduled Run Frequency , Clean Go Tidy & Generate , Find New Flaky Tests In Root Project / Find Tests To Run , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , lint , Find New Flaky Tests In Deployment Project , Find New Flaky Tests In Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/ccip_integration_tests... , Find New Flaky Tests In Root Project / Report , Flakey Test Detection , SonarQube Scan

1. Comment formatting issue: Golang Lint

Source of Error: 
Golang Lint 2024-11-14T17:38:07.6008480Z ##[error]core/capabilities/ccip/ccip_integration_tests/ccipreader/ccipreader_test.go:542:2: commentFormatting: put a space between `//` and comment text (gocritic)
Golang Lint 2024-11-14T17:38:07.6010363Z 	//timestamp := time.Now().Unix()
Golang Lint 2024-11-14T17:38:07.6010926Z 	^

Why: The comment does not have a space between the // and the comment text, which violates the gocritic linter rule.

Suggested fix: Add a space between // and the comment text.

2. Comment formatting issue: Golang Lint

Source of Error: 
Golang Lint 2024-11-14T17:38:07.6013212Z ##[error]core/capabilities/ccip/ccip_integration_tests/ccipreader/ccipreader_test.go:556:2: commentFormatting: put a space between `//` and comment text (gocritic)
Golang Lint 2024-11-14T17:38:07.6015835Z 	//assert.Equal(t, time.Unix(timestamp, 0), updates[chainS1].Timestamp)
Golang Lint 2024-11-14T17:38:07.6016652Z 	^

Why: The comment does not have a space between the // and the comment text, which violates the gocritic linter rule.

Suggested fix: Add a space between // and the comment text.

3. Goimports issue: Golang Lint

Source of Error: 
Golang Lint 2024-11-14T17:38:07.6018489Z core/capabilities/ccip/ccip_integration_tests/ccipreader/ccipreader_test.go:5: File is not `goimports`-ed with -local github.com/smartcontractkit/chainlink (goimports)
Golang Lint 2024-11-14T17:38:07.6020811Z 	"github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/fee_quoter"

Why: The file is not formatted according to goimports with the -local flag set to github.com/smartcontractkit/chainlink.

Suggested fix: Run goimports with the -local flag to format the imports correctly.

4. Ineffectual assignment: Golang Lint

Source of Error: 
Golang Lint 2024-11-14T17:38:07.6023049Z ##[error]core/capabilities/ccip/ccip_integration_tests/ccipreader/ccipreader_test.go:532:5: ineffectual assignment to err (ineffassign)
Golang Lint 2024-11-14T17:38:07.6024461Z 	_, err = feeQuoter.UpdatePrices(
Golang Lint 2024-11-14T17:38:07.6025190Z 	 ^

Why: The variable err is assigned a value but never used, which is flagged by the ineffassign linter.

Suggested fix: Use the err variable or remove the assignment if it is not needed.

5. Test failure due to out of gas: Run tests with flakeguard

Source of Error: 
Run tests with flakeguard 2024-11-14T17:38:44.8510472Z 	Error Trace:	/home/runner/work/chainlink/chainlink/core/capabilities/ccip/ccip_integration_tests/ccipreader/ccipreader_test.go:529
Run tests with flakeguard 2024-11-14T17:38:44.8512416Z 	Error: 	Received unexpected error:
Run tests with flakeguard 2024-11-14T17:38:44.8513363Z 	 	contract creation code storage out of gas
Run tests with flakeguard 2024-11-14T17:38:44.8514193Z 	Test: 	Test_GetChainFeePriceUpdates

Why: The test Test_GetChainFeePriceUpdates failed because the contract creation code ran out of gas.

Suggested fix: Increase the gas limit for the contract creation in the test setup to ensure it has enough gas to execute.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@github-actions GitHub Actions
Copy link
Contributor

Flaky Test Detector for ./go.mod project has failed ❌

Ran new or updated tests between ccipreader-tests and 1b586f7 (get-chain-fee-updates).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 7 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                                                        TestName                      PassRatio  RunCount   Skipped
---------                                                                                          ---------                     ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/ccip_integration_tests/ccipreader  Test_GetChainFeePriceUpdates  0%         1          false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@rstout rstout Awaiting requested review from rstout rstout is a code owner automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@mateusz-sekara mateusz-sekara Awaiting requested review from mateusz-sekara mateusz-sekara is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xnogo 0xnogo Awaiting requested review from 0xnogo 0xnogo is a code owner automatically assigned from smartcontractkit/ccip-offchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asoliman92